fix(ci): setup MSVC environment for Windows ARM64 builds#489
Merged
Conversation
The ring crate build was failing with 'assert.h not found' error because clang couldn't find the Windows SDK headers. This happens when building for aarch64-pc-windows-msvc without the proper MSVC environment variables. This fix adds the ilammy/msvc-dev-cmd action to set up the MSVC developer command prompt environment (INCLUDE, LIB, LIBPATH, etc.) before building. The action is configured with 'amd64_arm64' arch for cross-compiling from x64 to ARM64. Reference: briansmith/ring#2135
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The ring crate build was failing on Windows ARM64 with:
Even though clang was found in PATH, it couldn't locate the Windows SDK headers because the MSVC environment variables (INCLUDE, LIB, LIBPATH, etc.) weren't set.
Solution
Added the
ilammy/msvc-dev-cmd@v1action to set up the MSVC developer command prompt environment before building. This action:arch: amd64_arm64for cross-compiling from x64 host to ARM64 targetThe action runs before the LLVM path setup step, ensuring clang has access to all Windows SDK headers.
References