Skip to content

Reject logs paths viewing flags#401

Open
GreyforgeLabs wants to merge 1 commit into
CortexLM:mainfrom
GreyforgeLabs:logs-paths-conflicts
Open

Reject logs paths viewing flags#401
GreyforgeLabs wants to merge 1 commit into
CortexLM:mainfrom
GreyforgeLabs:logs-paths-conflicts

Conversation

@GreyforgeLabs
Copy link
Copy Markdown

Summary

  • Configure logs --paths to reject viewing-only flags instead of silently ignoring them.
  • Keep plain logs --paths valid with the default line count.
  • Add CLI regression coverage for --follow, --level, and explicit --lines conflicts.

Fixes PlatformNetwork/bounty-challenge#52724.

Validation

  • cargo test -p cortex-cli --test logs_paths_conflicts --no-default-features --features cortex-tui -- --nocapture
  • cargo check -p cortex-cli --no-default-features --features cortex-tui
  • cargo fmt --package cortex-cli --check
  • git diff --check
  • git diff --cached --check

Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] cortex logs --paths silently ignores --follow, --level, and --lines instead of rejecting incompatible combinations

1 participant