Skip to content

Match log levels exactly#404

Open
GreyforgeLabs wants to merge 1 commit into
CortexLM:mainfrom
GreyforgeLabs:logs-level-exact-match
Open

Match log levels exactly#404
GreyforgeLabs wants to merge 1 commit into
CortexLM:mainfrom
GreyforgeLabs:logs-level-exact-match

Conversation

@GreyforgeLabs
Copy link
Copy Markdown

Summary

  • Parse log lines for recognized level tokens instead of searching full message text.
  • Use exact log-level comparison for logs --level and follow-mode filtering.
  • Add CLI regression coverage for message text false positives and partial level names.

Fixes PlatformNetwork/bounty-challenge#51536.

Validation

  • cargo test -p cortex-cli --test logs_level_filter --no-default-features --features cortex-tui -- --nocapture
  • cargo check -p cortex-cli --no-default-features --features cortex-tui
  • cargo fmt --package cortex-cli --check
  • git diff --check
  • git diff --cached --check

Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [v0.0.7] Log level filtering uses substring matching, causing false positives

1 participant