Accept pwsh for shell completions

src/cortex-cli/src/cli/args.rs

@@ -551,14 +551,27 @@ pub struct LogoutCommand {
 #[derive(Args)]
 pub struct CompletionCommand {
     /// Shell to generate completions for.
-    #[arg(value_enum)]
+    #[arg(value_parser = parse_completion_shell)]
     pub shell: Option<clap_complete::Shell>,
 
     /// Install completions to your shell configuration file.
     #[arg(long = "install")]
     pub install: bool,
 }
 
+fn parse_completion_shell(value: &str) -> Result<clap_complete::Shell, String> {
+    match value.to_ascii_lowercase().as_str() {
+        "bash" => Ok(clap_complete::Shell::Bash),
+        "elvish" => Ok(clap_complete::Shell::Elvish),
+        "fish" => Ok(clap_complete::Shell::Fish),
+        "powershell" | "pwsh" => Ok(clap_complete::Shell::PowerShell),
+        "zsh" => Ok(clap_complete::Shell::Zsh),
+        _ => Err(format!(
+            "invalid shell '{value}'; expected one of bash, elvish, fish, powershell, pwsh, zsh"
+        )),
+    }
+}
+
 /// Init command - initialize AGENTS.md.
 #[derive(Args)]
 pub struct InitCommand {
@@ -1754,6 +1767,17 @@ mod tests {
         }
     }
 
+    #[test]
+    fn test_completion_command_pwsh_alias() {
+        let cli = Cli::try_parse_from(["cortex", "completion", "pwsh"])
+            .expect("should parse completion pwsh");
+        if let Some(Commands::Completion(completion)) = cli.command {
+            assert_eq!(completion.shell, Some(clap_complete::Shell::PowerShell));
+        } else {
+            panic!("Expected Completion command");
+        }
+    }
+
     #[test]
     fn test_completion_command_install() {
         let cli = Cli::try_parse_from(["cortex", "completion", "--install"])

src/cortex-cli/tests/completion_pwsh.rs

@@ -0,0 +1,30 @@
+use std::fs;
+use std::process::Command;
+
+use tempfile::tempdir;
+
+#[test]
+fn completion_pwsh_is_accepted_as_powershell_alias() {
+    let home = tempdir().unwrap();
+    let output = Command::new(env!("CARGO_BIN_EXE_Cortex"))
+        .args(["completion", "pwsh", "--install"])
+        .env("HOME", home.path())
+        .output()
+        .unwrap();
+
+    assert!(
+        output.status.success(),
+        "completion pwsh failed:\n{}{}",
+        String::from_utf8_lossy(&output.stdout),
+        String::from_utf8_lossy(&output.stderr)
+    );
+
+    let profile = home
+        .path()
+        .join(".config/powershell/Microsoft.PowerShell_profile.ps1");
+    let profile = fs::read_to_string(profile).unwrap();
+    assert!(
+        profile.contains("cortex completion powershell"),
+        "profile:\n{profile}"
+    );
+}