Skip to content

Fix repeated update banner notifications#406

Open
SatorSK wants to merge 1 commit into
CortexLM:mainfrom
SatorSK:fix-update-banner-notified
Open

Fix repeated update banner notifications#406
SatorSK wants to merge 1 commit into
CortexLM:mainfrom
SatorSK:fix-update-banner-notified

Conversation

@SatorSK
Copy link
Copy Markdown

@SatorSK SatorSK commented May 20, 2026

Fixes PlatformNetwork/bounty-challenge#53190.

Summary

  • Use last_notified_version for startup update notifications
  • Suppress repeat banners for the same latest version
  • Keep regular check_update() behavior unchanged for explicit update/install flows
  • Add focused config coverage for notification tracking

Why

The update config already had last_notified_version, but the startup update check never consulted or persisted it. This meant the same available-update banner could reappear on every launch. The new notification-specific check records the version after surfacing it, while explicit update checks still report available updates normally.

Verification

  • rustfmt --edition 2024 --check src\\cortex-update\\src\\config.rs src\\cortex-update\\src\\manager.rs src\\cortex-tui\\src\\runner\\app_runner\\runner.rs
  • cargo check -p cortex-tui
  • cargo test -p cortex-update --lib compiled but the Windows test executable could not run because it requires elevation (os error 740)

Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Update banner can reappear on every launch because last_notified_version is never used

2 participants