Fix repeated update banner notifications#406
Open
SatorSK wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes PlatformNetwork/bounty-challenge#53190.
Summary
last_notified_versionfor startup update notificationscheck_update()behavior unchanged for explicit update/install flowsWhy
The update config already had
last_notified_version, but the startup update check never consulted or persisted it. This meant the same available-update banner could reappear on every launch. The new notification-specific check records the version after surfacing it, while explicit update checks still report available updates normally.Verification
rustfmt --edition 2024 --check src\\cortex-update\\src\\config.rs src\\cortex-update\\src\\manager.rs src\\cortex-tui\\src\\runner\\app_runner\\runner.rscargo check -p cortex-tuicargo test -p cortex-update --libcompiled but the Windows test executable could not run because it requires elevation (os error 740)