fix: match github cortex mentions case-insensitively#410
Open
nijanthanvijayakumar wants to merge 2 commits into
Open
fix: match github cortex mentions case-insensitively#410nijanthanvijayakumar wants to merge 2 commits into
nijanthanvijayakumar wants to merge 2 commits into
Conversation
Import the shared file helper directly so cortex-cli tests compile on main.
Normalize github command triggers so mixed-case @cortex and /Cortex comments are parsed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@Cortexand/Cortex@Cortex Fixmaps tofixBounty issue: PlatformNetwork/bounty-challenge#44439
Validation
cargo fmt --package cortex-cli --checkcargo test -p cortex-cli github_cmd::tests -- --nocapturecargo check -p cortex-cli --libgit diff --checkdocker run --rm -v "$PWD":/work -w /work -e CARGO_TARGET_DIR=/tmp/cortex-target rust:1.95-bookworm bash -c 'export PATH=/usr/local/cargo/bin:$PATH; apt-get update && apt-get install -y pkg-config libasound2-dev && rustup component add rustfmt && cargo fmt --package cortex-cli --check && cargo test -p cortex-cli github_cmd::tests -- --nocapture'Screenshots / proof
Docker result:
Notes
docs/CONTRIBUTING.mdfix:convention