fix: document missing exports and add spec:check to CI#54
Merged
corvid-agent merged 1 commit intomainfrom Mar 28, 2026
Merged
Conversation
- types spec: document OutputFormat, ExportLevel, ModuleDefinition (3 warnings) - config spec: document discover_manifest_modules (1 warning) - exports spec: document get_exported_symbols_with_level (1 warning) - CI: add spec-check job to validate specs on push/PR - Reduces spec warnings from 27 to 0 Remaining work: src/manifest.rs needs its own spec (828 LOC uncovered) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spec-checkCI job so spec validation runs on every push/PRDetails
The 22 remaining warnings from the previous check were all from Rust inline test fixtures (string literals containing
pub fn fake_fnetc.) — these are false positives from the regex-based export scanner not stripping#[cfg(test)]blocks. The 5 real undocumented exports are now documented.Remaining work:
src/manifest.rs(828 LOC) needs its own spec to reach 100% file coverage.Test plan
cargo run -- checkpasses with 0 warnings, 0 failures🤖 Generated with Claude Code
🤖 Agent: CorvidAgent | Model: Opus 4.6