Skip to content

Conversation

@CosimoTiger
Copy link
Owner

  • add missing class documentation
  • implement Maximum zero time return alternative for ICooldown.getRemaining() #24 by renaming getRemaining into getDifference and adding getRemaining which returns time until expiration, minimally zero
  • rename Cooldowns.cleanup to Cooldowns.clearExpired for better clarification
  • add getDifference to the tests
  • improve some parts of the tests
  • make the cooldown tests concurrent again because some of them are using Thread.sleep

@CosimoTiger CosimoTiger added documentation Improvements or additions to documentation feature New feature or request for one labels Jan 6, 2025
@CosimoTiger CosimoTiger self-assigned this Jan 6, 2025
@CosimoTiger CosimoTiger linked an issue Jan 6, 2025 that may be closed by this pull request
@CosimoTiger CosimoTiger merged commit 9e58d81 into main Jan 6, 2025
1 check passed
@CosimoTiger CosimoTiger deleted the feature/improve-cooldowns branch January 6, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation feature New feature or request for one

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Maximum zero time return alternative for ICooldown.getRemaining()

2 participants