Document the use of data: Some(b"") for clearing data #982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanfrey
approved these changes
Jun 24, 2021
Contributor
ethanfrey
left a comment
ethanfrey
left a comment
There was a problem hiding this comment.
Fine with me since we did check this works.
Alex, I guess you need to double-check the handling in wasmd or []byte and strings.
Contributor
|
I have opened an issue in wasmd to change the logic to match this case. |
alpe
approved these changes
Jun 24, 2021
Contributor
alpe
left a comment
alpe
left a comment
There was a problem hiding this comment.
👍 Good definition. Please wait to merge this for the patch in wasmd
Member
Author
|
Thanks! Merging now was part of the package CosmWasm 0.15 + wasmd 0.18. The change in CosmWasm/wasmd#534 should be unreleased until we cut 0.18 anyways. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative approach to #949, which is more feature rich.
In contrast to Go
strings, the deserialization into[]byteallows converting JSONnullto Gonileasily.Closes #949