Skip to content

Conversation

@webmaster128
Copy link
Member

@webmaster128 webmaster128 commented Apr 30, 2020

Based on #12. Will update when this is in.


This implements quote detection. It fails since it interpretes \\" as an escaped ".

This does not yet try to unescape any value. It is just about finding the end of a string.

@webmaster128 webmaster128 force-pushed the deserialize branch 2 times, most recently from 6089d58 to 9a38299 Compare May 4, 2020 12:28
@webmaster128 webmaster128 changed the title Deserialize: Attempt to detect string quotes correctly Deserialize: Detect string quotes correctly May 4, 2020
@webmaster128 webmaster128 marked this pull request as ready for review May 4, 2020 21:28
@webmaster128 webmaster128 requested a review from ethanfrey May 4, 2020 21:29
@webmaster128 webmaster128 changed the title Deserialize: Detect string quotes correctly Deserialize: Detect string end quotes correctly May 4, 2020
Copy link

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants