Merged
Conversation
- Remove dead 'rows' variable left over from the develop-branch merge in the state-only path of LocateForm (caused ESLint no-unused-vars error) - Apply prettier auto-format to Locate.tsx, helpers.ts, locate-hsm.spec.ts (new .prettierrc.json introduced by develop; pnpm run check now passes) - Add test-results/ and playwright-report/ to ui/.gitignore so that Playwright output directories are excluded from prettier --check
- Replace ps -p with kill -0 in kms_wait_ready (common.sh): ps is not in pure Nix shell PATH on macOS, causing false dead-process detection - Switch test_ui.sh to --config TOML (no ui_index_html_folder) to avoid macOS /etc/cosmian/kms.toml conflict and Linux CI server early exit - Remove PLAYWRIGHT_KMS_HAS_HSM guard since SoftHSM2 is always required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.