Skip to content

Dse/run runner prod 14842#402

Merged
sellisd merged 17 commits intomainfrom
DSE/run_runner_PROD-14842
Oct 15, 2025
Merged

Dse/run runner prod 14842#402
sellisd merged 17 commits intomainfrom
DSE/run_runner_PROD-14842

Conversation

@sellisd
Copy link
Contributor

@sellisd sellisd commented Oct 13, 2025

No description provided.

@sellisd sellisd requested review from MohcineTor and Copilot October 13, 2025 12:27
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the codebase by renaming "scenarios" to "runners" and "scenarioruns" to "runs" throughout the API structure. It also removes the deprecated ABBA command module and updates authentication from Azure tokens to Keycloak tokens.

  • Renames scenario-related API endpoints and services to runner-related equivalents
  • Replaces scenariorun functionality with simplified run functionality
  • Removes the entire ABBA module for batch scenario processing
  • Switches authentication mechanism from Azure to Keycloak tokens

Reviewed Changes

Copilot reviewed 35 out of 40 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
Babylon/test/api/runs/test_run_service.py Updates test class and imports for new run service, removes cumulated_logs test
Babylon/test/api/runners/test_runner_service.py Updates test class and imports for new runner service, changes test data references
Babylon/commands/macro/destroy.py Updates import and service instantiation for runners
Babylon/commands/api/scenarios/apply.py Removes entire scenario apply command file
Babylon/commands/api/scenarioruns/ Removes all scenariorun-related files and services
Babylon/commands/api/runs/ Adds new run-related commands (logs, status, stop) with Keycloak auth
Babylon/commands/api/runners/ Adds new runner-related commands and services with Keycloak auth
Babylon/commands/abba/ Removes entire ABBA module for batch processing
Babylon/commands/init.py Removes ABBA from command groups
.github/workflows/ci.yml Updates CI tests to include runs and runners

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

Copilot AI Oct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The log message still references 'Scenario run' but should be updated to 'Runner run' to match the refactoring from scenarios to runners.

Suggested change
logger.info(f"Scenario run {runner_run['id']} has been successfully added to state")
logger.info(f"Runner run {runner_run['id']} has been successfully added to state")

Copilot uses AI. Check for mistakes.
Comment on lines 58 to 60
Copy link

Copilot AI Oct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The log messages still reference 'Scenario' but should be updated to 'Runner' to match the refactoring from scenarios to runners.

Suggested change
logger.info(f'Scenario {service_state["api"]["runner_id"]} successfully updated')
if service_state["api"]["runner_id"] == state["services"]["api"]["runner_id"]:
logger.info(f'Scenario {state["services"]["api"]["runner_id"]} stored in state has been successfully updated')
logger.info(f'Runner {service_state["api"]["runner_id"]} successfully updated')
if service_state["api"]["runner_id"] == state["services"]["api"]["runner_id"]:
logger.info(f'Runner {state["services"]["api"]["runner_id"]} stored in state has been successfully updated')

Copilot uses AI. Check for mistakes.
Comment on lines 45 to 51
Copy link

Copilot AI Oct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The log messages still reference 'Scenario' but should be updated to 'Runner' to match the refactoring from scenarios to runners.

Copilot uses AI. Check for mistakes.
Comment on lines 45 to 51
Copy link

Copilot AI Oct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The log messages still reference 'Scenario' but should be updated to 'Runner' to match the refactoring from scenarios to runners.

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Oct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The log message still references 'Scenario' but should be updated to 'Runner' to match the refactoring from scenarios to runners.

Suggested change
logger.info(f"Scenario {runner['id']} has been successfully added in state")
logger.info(f"Runner {runner['id']} has been successfully added in state")

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Oct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error message refers to 'solution id' but should refer to 'run id' based on the context and the check for self.run_id on line 20.

Suggested change
logger.error("solution id is missing")
logger.error("run id is missing")

Copilot uses AI. Check for mistakes.
@sellisd sellisd marked this pull request as ready for review October 13, 2025 12:40
@MohcineTor MohcineTor force-pushed the DSE/run_runner_PROD-14842 branch from a1fe047 to 4041988 Compare October 15, 2025 09:33
Copy link
Collaborator

@MohcineTor MohcineTor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sellisd sellisd merged commit 6c42736 into main Oct 15, 2025
4 checks passed
@sellisd sellisd deleted the DSE/run_runner_PROD-14842 branch October 15, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments