Delete scenario metadata #338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcarluer
suggested changes
Sep 22, 2022
Contributor
vcarluer
left a comment
vcarluer
left a comment
There was a problem hiding this comment.
Reviewed with @jreynard-code
Please retest after correction: deleting 1 scenariorun should not delete any scenario data
scenariorun/src/main/kotlin/com/cosmotech/scenariorun/azure/ScenarioRunServiceImpl.kt
Outdated
Show resolved
Hide resolved
michel-guillon
force-pushed
the
delete_scenario_data_in_adx_Prod-9897
branch
from
12c9451 to
eea1749
Compare
Contributor
|
IMHO: Squashing all commits we lose completely track of previous PR and what have been done for a feature |
vcarluer
suggested changes
Sep 23, 2022
scenariorun/src/main/kotlin/com/cosmotech/scenariorun/azure/ScenarioRunServiceImpl.kt
Outdated
Show resolved
Hide resolved
scenariorun/src/main/kotlin/com/cosmotech/scenariorun/azure/ScenarioRunServiceImpl.kt
Outdated
Show resolved
Hide resolved
vcarluer
suggested changes
Sep 23, 2022
Contributor
vcarluer
left a comment
vcarluer
left a comment
There was a problem hiding this comment.
duplicate deletion call
| organizationId, scenarioRun.workspaceKey!!, scenarioRun.csmSimulationRun!!) | ||
| } | ||
|
|
||
| private fun deleteScenarioRunMetadata( |
Contributor
There was a problem hiding this comment.
This method is not needed: ADX csmSimulation drop by extent already done in deleteScenarioRunWithoutAccessEnforcement line 135
| } | ||
| this.deleteScenarioRunWithoutAccessEnforcement(scenarioRun) | ||
| deleteScenarioRunWithoutAccessEnforcement(scenarioRun) | ||
| deleteScenarioRunMetadata( |
Contributor
There was a problem hiding this comment.
This method call is not needed: ADX csmSimulation drop by extent already done in deleteScenarioRunWithoutAccessEnforcement line 135
…letion because redundant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.