Mig/delete old scenariorun prod 9734

[michel-guillon]

No description provided.

[vcarluer]

reuse @LeopoldCramer method

[jreynard-code]

Some changes ;)

[jreynard-code]

Please do not write while(true) it's awful.
try something like this

  private fun deletePreviousSimulationDataIfCurrentSimulationIsSuccessful(currentRun: ScenarioRun) {
    val scenarioRunId = currentRun.id!!
    val workspaceId = currentRun.workspaceId!!
    val organizationId = currentRun.organizationId!!
    val scenarioId = currentRun.scenarioId!!
    val csmSimulationRun = currentRun.csmSimulationRun

    var scenarioRunStatus = getScenarioRunStatus(organizationId, scenarioRunId)
    while (
      scenarioRunStatus.state != ScenarioRunState.Successful ||
      scenarioRunStatus.state != ScenarioRunState.Failed ||
      scenarioRunStatus.state != ScenarioRunState.DataIngestionFailure ) {
      logger.info("ScenarioRun {} is still running, waiting for purging data", csmSimulationRun)
      Thread.sleep(10000)
      scenarioRunStatus = getScenarioRunStatus(organizationId, scenarioRunId)
    }

    if (scenarioRunStatus.state == ScenarioRunState.Successful) {
      logger.info("ScenarioRun {} is Successfull => purging data", csmSimulationRun)
      deleteScenarioRunsByScenario(organizationId, workspaceId, scenarioId)
    } else {
      logger.info("ScenarioRun {} is in error {} => no purging data",
        csmSimulationRun,
        scenarioRunStatus.state)
    }

  }

Note that the value 10000 should be configurable

[michel-guillon]

It's a sore in the eye
with the following code the intention is clear and neat

private fun deletePreviousSimulationDataIfCurrentSimulationIsSuccessful(currentRun: ScenarioRun) {
while (true) {
Thread.sleep(10000)
val scenarioRunStatus = getScenarioRunStatus(currentRun.organizationId!!, currentRun.id!!)

  if (scenarioRunStatus.state == ScenarioRunState.Successful) {
    deleteScenarioRunsByScenario(
        currentRun.organizationId!!, currentRun.workspaceId!!, currentRun.scenarioId!!)
    return
  } else if (scenarioRunStatus.state == ScenarioRunState.DataIngestionFailure ||
      scenarioRunStatus.state == ScenarioRunState.Failed) {
    logger.info("ScenarioRun {} failed", currentRun.csmSimulationRun)
    break
  }
}

}

[jreynard-code]

LGTM