Add create graph endpoint #487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreynard-code
approved these changes
Apr 27, 2023
Member
jreynard-code
left a comment
jreynard-code
left a comment
There was a problem hiding this comment.
LGTM ;)
As we discussed, changes will be done after merge...
...rc/integrationTest/kotlin/com/cosmotech/twingraph/service/TwingraphServiceIntegrationTest.kt
Show resolved
Hide resolved
...rc/integrationTest/kotlin/com/cosmotech/twingraph/service/TwingraphServiceIntegrationTest.kt
Show resolved
Hide resolved
| mutableMapOf( | ||
| "lastVersion" to "1", | ||
| "graphName" to graphId, | ||
| "graphRotation" to "3", |
Member
There was a problem hiding this comment.
Could you please add graphRotation as optional parameter with default value to 2 ?
|
|
||
| queryBuffer.send() | ||
| } else { | ||
| getEntities(organizationId, graphId, "node", listOf("node_a")) |
twingraph/src/main/kotlin/com/cosmotech/twingraph/api/TwingraphServiceImpl.kt
Show resolved
Hide resolved
| } | ||
|
|
||
| (prop as String).also { | ||
| if (it == "") type = PropertyType.BI_NULL |
Member
There was a problem hiding this comment.
it.isNullOrBlank() instead
| fun addNodes(vararg nodesArg: Node) { | ||
| nodesArg.forEach { | ||
| if (it.properties.keys.any { s -> s !in header }) | ||
| // TODO create specific exception |
| tasks.add(currentBulkQueryBuilder.build()) | ||
|
|
||
| tasks.forEach { query -> | ||
| println(query.toString()) |
Member
There was a problem hiding this comment.
To remove or replace by logger
| println(query.toString()) | ||
| val result = jedis.sendCommand({ "GRAPH.BULK".toByteArray() }, *query.generateQueryArgs()) | ||
|
|
||
| println((result as ByteArray).toString(Charset.defaultCharset())) |
Member
There was a problem hiding this comment.
To remove or replace by logger
Comment on lines
+395
to
+400
| # - name: graph_model | ||
| # in: query | ||
| # description: the Graph Model | ||
| # required: false | ||
| # schema: | ||
| # type: object |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.