Skip to content

Conversation

@neomatamune
Copy link
Member

used string date for lisibility

used string date for lisibility
@neomatamune neomatamune force-pushed the AFOS/add_scenariorun_createddate_PROD-11762 branch from aba3d35 to 5c656ec Compare July 20, 2023 09:14
Copy link
Member

@jreynard-code jreynard-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sdkVersion:
type: string
description: the MAJOR.MINOR version used to build the solution solution
creationDate:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the look I took when adding similar fields to the modeling API, it seems other time point fields use a <action>edAt name pattern, should this one be consisent too and be createdAt?

@jreynard-code jreynard-code self-requested a review July 21, 2023 07:33
@neomatamune neomatamune force-pushed the AFOS/add_scenariorun_createddate_PROD-11762 branch from 14dfb2c to 69be530 Compare August 7, 2023 09:21
@neomatamune neomatamune merged commit 25c7918 into main Aug 7, 2023
@neomatamune neomatamune deleted the AFOS/add_scenariorun_createddate_PROD-11762 branch August 7, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants