Skip to content

Conversation

@lalepee
Copy link
Contributor

@lalepee lalepee commented Oct 16, 2023

only delete when dataset create by v3 api. Check with the newly created creationDate property which is null for previous version

only delete when dataset create by v3 api. Check with the newly created creationDate property which is null for previous version
Copy link
Contributor

@Leopold-Cramer Leopold-Cramer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Leopold-Cramer Leopold-Cramer self-requested a review October 16, 2023 14:20
Copy link
Contributor

@Leopold-Cramer Leopold-Cramer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add tests pls :/

@lalepee lalepee force-pushed the LALE/fix_dataset_deletion_PROD-12512 branch from ef0caec to c9da744 Compare October 17, 2023 15:32
Copy link
Contributor

@Leopold-Cramer Leopold-Cramer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :(

@lalepee lalepee merged commit 772afa8 into main Oct 18, 2023
@lalepee lalepee deleted the LALE/fix_dataset_deletion_PROD-12512 branch October 18, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants