-
Notifications
You must be signed in to change notification settings - Fork 1
Lcra/avoid multiple occurence same user security prod 12648 #595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Leopold-Cramer
merged 6 commits into
main
from
LCRA/avoid_multiple_occurence_same_user_security_PROD-12648
Nov 24, 2023
Merged
Lcra/avoid multiple occurence same user security prod 12648 #595
Leopold-Cramer
merged 6 commits into
main
from
LCRA/avoid_multiple_occurence_same_user_security_PROD-12648
Nov 24, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalepee
requested changes
Nov 21, 2023
...et/src/integrationTest/kotlin/com/cosmotech/dataset/service/DatasetServiceIntegrationTest.kt
Show resolved
Hide resolved
dataset/src/main/kotlin/com/cosmotech/dataset/service/DatasetServiceImpl.kt
Outdated
Show resolved
Hide resolved
...egrationTest/kotlin/com/cosmotech/organization/service/OrganizationServiceIntegrationTest.kt
Show resolved
Hide resolved
organization/src/main/kotlin/com/cosmotech/organization/service/OrganizationServiceImpl.kt
Outdated
Show resolved
Hide resolved
.../src/integrationTest/kotlin/com/cosmotech/scenario/service/ScenarioServiceIntegrationTest.kt
Show resolved
Hide resolved
scenario/src/main/kotlin/com/cosmotech/scenario/service/ScenarioServiceImpl.kt
Outdated
Show resolved
Hide resolved
.../src/integrationTest/kotlin/com/cosmotech/solution/service/SolutionServiceIntegrationTest.kt
Show resolved
Hide resolved
solution/src/main/kotlin/com/cosmotech/solution/service/SolutionServiceImpl.kt
Outdated
Show resolved
Hide resolved
...rc/integrationTest/kotlin/com/cosmotech/worskpace/service/WorkspaceServiceIntegrationTest.kt
Show resolved
Hide resolved
workspace/src/main/kotlin/com/cosmotech/workspace/service/WorkspaceServiceImpl.kt
Outdated
Show resolved
Hide resolved
…times add in each services check to endpoints: -create -update -add AC
changed descriptions of update endpoints in the following services to warn not to use those endpoints to change the security -organization -solution -dataset -workspace -scenario
26e1cc4 to
94d036d
Compare
lalepee
approved these changes
Nov 23, 2023
Contributor
lalepee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes
.../src/integrationTest/kotlin/com/cosmotech/scenario/service/ScenarioServiceIntegrationTest.kt
Show resolved
Hide resolved
.../src/integrationTest/kotlin/com/cosmotech/solution/service/SolutionServiceIntegrationTest.kt
Show resolved
Hide resolved
4a69e61 to
c4c2e86
Compare
c4c2e86 to
f27d34a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.