Skip to content

Conversation

@Leopold-Cramer
Copy link
Contributor

No description provided.

Copy link
Contributor

@lalepee lalepee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments on format

}

@Test
fun `when workspace datasetCopy is false, users added to scenario RBAC should not have the same role in dataset`() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

naming: should have at least role viewer

scenario = makeScenario(datasetList = mutableListOf(datasetSaved.id!!))
scenarioSaved =
scenarioApiService.createScenario(organizationSaved.id!!, workspaceSaved.id!!, scenario)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line break is meaningless.
Group prepare action, act action and assert action

@jreynard-code jreynard-code force-pushed the LCRA/modify_linked_datasets_behaviors_when_not_copy_PROD-12972_PROD-12973 branch from 6248d8f to cd797dd Compare January 19, 2024 14:24
@Leopold-Cramer Leopold-Cramer force-pushed the LCRA/modify_linked_datasets_behaviors_when_not_copy_PROD-12972_PROD-12973 branch from cd797dd to f575fd0 Compare January 19, 2024 14:28
@jreynard-code jreynard-code force-pushed the LCRA/modify_linked_datasets_behaviors_when_not_copy_PROD-12972_PROD-12973 branch from cb4d796 to 4455533 Compare January 19, 2024 14:42
@jreynard-code jreynard-code force-pushed the LCRA/modify_linked_datasets_behaviors_when_not_copy_PROD-12972_PROD-12973 branch from 4455533 to a2fda0e Compare January 19, 2024 14:56
@jreynard-code jreynard-code merged commit bb47e3c into release/v3.0 Jan 19, 2024
@jreynard-code jreynard-code deleted the LCRA/modify_linked_datasets_behaviors_when_not_copy_PROD-12972_PROD-12973 branch January 19, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants