fix: fix Python client error when fetching legacy datasets #641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, a call to find_dataset_by_id on a dataset created with v2 of the Cosmo Tech API raised this error: cosmotech_api.exceptions.ApiValueError: Invalid value for `ingestion_status` (None), must be one of ['NONE', 'PENDING', 'ERROR', 'SUCCESS'] or a similar error for twincacheStatus. This is because "legacy" datasets have null values for these attributes (and for the attribute 'sourceType', but this one has 'None' explicitly allowed in the enum values). To fix this error, this commit adds "nullable: true" for the attributes ingestionStatus and twincacheStatus in the openapi.yaml file.
csm-thu
deleted the
THU/fix_python_client_error_on_null_fields_in_legacy_datasets
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, a call to
find_dataset_by_idon a dataset created with v2 of the Cosmo Tech API raised this error:or a similar error for
twincacheStatus. This is because "legacy" datasets have null values for these attributes (and for the attributesourceType, but this one hasNoneexplicitly allowed in the enum values).To fix this error, this commit adds
nullable: truefor the attributesingestionStatusandtwincacheStatusin the openapi.yaml file.