Skip to content

Outsource vos commands to cs_util#606

Merged
sfarrens merged 8 commits intoCosmoStat:developfrom
martinkilbinger:vos
Sep 6, 2023
Merged

Outsource vos commands to cs_util#606
sfarrens merged 8 commits intoCosmoStat:developfrom
martinkilbinger:vos

Conversation

@martinkilbinger
Copy link
Copy Markdown
Contributor

@martinkilbinger martinkilbinger commented Jan 17, 2023 •
edited by sfarrens
Loading

Summary

The vos (VIrtual ObServatory) commands in canfar.py are moved to the library cs_util. These are used also elsewhere.
Need to wait for v 0.0.3 of cs_util, CosmoStat/cs_util#14, and #606

Reviewer Checklist

Reviewers should tick the following boxes before approving and merging the PR.

  • The PR targets the develop branch
  • The PR is assigned to the developer
  • The PR has appropriate labels
  • The PR is included in appropriate projects and/or milestones
  • The PR includes a clear description of the proposed changes
  • If the PR addresses an open issue the description includes "closes #"
  • The code and documentation style match the current standards
  • Documentation has been added/updated consistently with the code
  • All CI tests are passing
  • API docs have been built and checked at least once (if relevant)
  • All changed files have been checked and comments provided to the developer
  • All of the reviewer's comments have been satisfactorily addressed by the developer

@martinkilbinger martinkilbinger self-assigned this Jan 17, 2023
@sfarrens
Copy link
Copy Markdown
Member

sfarrens commented May 10, 2023

v0.0.4 of cs_util needs to be released before this PR can be merged.

@martinkilbinger
Copy link
Copy Markdown
Contributor Author

martinkilbinger commented Jul 14, 2023

v0.0.4 of cs_util needs to be released before this PR can be merged.

Done, should work now.

sfarrens
sfarrens reviewed Sep 6, 2023
View reviewed changes
Comment thread environment.yml Outdated
@martinkilbinger @sfarrens
Update environment.yml
d6d9458 
Co-authored-by: Samuel Farrens <samuel.farrens@gmail.com>
@sfarrens sfarrens merged commit 0103694 into CosmoStat:develop Sep 6, 2023
martinkilbinger added a commit to martinkilbinger/shapepipe-1 that referenced this pull request Feb 13, 2025
@martinkilbinger @sfarrens
Outsource vos commands to cs_util (CosmoStat#606)
a2e5a47 
* removed shapepipe/utilities/canfar.py, moved to cs_util (0.0.4)

* removed unused imports

* modif to mccd config file (run_datetime)

* env yml: cs_util is pip, not conda package

* Update environment.yml

Co-authored-by: Samuel Farrens <samuel.farrens@gmail.com>

---------

Co-authored-by: Samuel Farrens <samuel.farrens@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sfarrens sfarrens sfarrens approved these changes

Assignees

@martinkilbinger martinkilbinger

Labels

clean up

Projects

ShapePipe Dev
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@martinkilbinger @sfarrens