Small changes for bookkeeping #618
Merged
martinkilbinger merged 18 commits intoCosmoStat:developfrom Jul 18, 2023
Merged
Conversation
| @@ -0,0 +1,90 @@ | |||
| # Mask module config file for tiles | |||
Contributor
There was a problem hiding this comment.
Is this config file being used?
| @@ -0,0 +1,462 @@ | |||
| #!/usr/bin/env bash | |||
Contributor
There was a problem hiding this comment.
should be in the scripts/sh directory.
Can this be merged with job_sp.bash?
| @@ -0,0 +1,24 @@ | |||
| -11.5 68 | |||
Contributor
There was a problem hiding this comment.
I think some of those files used for masking (e.g. Messier & NGC objects) are not used.
| """ | ||
|
|
||
| def __init__(self, img_tile_path, output_path, w_log, colnum): | ||
| def __init__(self, img_tile_path, output_path, w_log, colnum, prefix): |
Contributor
There was a problem hiding this comment.
Update class doc string
| colnum = config.getint(module_config_sec, 'COLNUM') | ||
|
|
||
| # Give the prefix of exposures | ||
| exp_prefix = config.get(module_config_sec, 'EXP_PREFIX') |
Contributor
There was a problem hiding this comment.
Update doc string in init.py
| ) | ||
| external_flag.open() | ||
| if final_mask is not None: | ||
| final_mask=final_mask.astype(np.int16, copy=False) |
Contributor
There was a problem hiding this comment.
spaces around '='.
Contributor
|
Write a brief summary of the PR, and set the assignment and label. |
As Martin suggested this file is not needed when running the simulation as config_tile.mask_simu is used
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I wanted to do this in two different pull requests but did not manage. This PR makes a few small changes in the modules for bookkeeping and adds config files to the example folder in cfis_simu which allowed me to run the simulated images through shapepipe.
Reviewer Checklist
developbranch