Skip to content

N epoch test#627

Merged
sfarrens merged 3 commits intoCosmoStat:developfrom
martinkilbinger:n_epoch_test
Sep 6, 2023
Merged

N epoch test#627
sfarrens merged 3 commits intoCosmoStat:developfrom
martinkilbinger:n_epoch_test

Conversation

@martinkilbinger
Copy link
Copy Markdown
Contributor

@martinkilbinger martinkilbinger commented May 15, 2023

Summary

In the PSFEx and MCCD interpolation modules, a check is added for the input key 'N_EPOCH'. A KeyError is raised if not present. Closes #626 .

Reviewer Checklist

Reviewers should tick the following boxes before approving and merging the PR.

  • The PR targets the develop branch
  • The PR is assigned to the developer
  • The PR has appropriate labels
  • The PR is included in appropriate projects and/or milestones
  • The PR includes a clear description of the proposed changes
  • If the PR addresses an open issue the description includes "closes #"
  • The code and documentation style match the current standards
  • Documentation has been added/updated consistently with the code
  • All CI tests are passing
  • API docs have been built and checked at least once (if relevant)
  • All changed files have been checked and comments provided to the developer
  • All of the reviewer's comments have been satisfactorily addressed by the developer

@martinkilbinger martinkilbinger added documentation Improvements or additions to documentation enhancement New feature or request labels May 15, 2023
@martinkilbinger martinkilbinger added this to the Re-run 2023 milestone May 15, 2023
@martinkilbinger martinkilbinger requested a review from lbaumo May 15, 2023 13:17
@martinkilbinger martinkilbinger self-assigned this May 15, 2023
@martinkilbinger
Copy link
Copy Markdown
Contributor Author

@lbaumo when you get a chance you can check this PR and accept (if everything is ok). The CI tests are failing due to the pysap issue, but we can ignore this here since only the documentation changed.

Comment thread shapepipe/modules/mccd_package/mccd_interpolation_script.py Outdated
Comment thread shapepipe/modules/psfex_interp_package/psfex_interp.py Outdated
@sfarrens sfarrens merged commit 1134756 into CosmoStat:develop Sep 6, 2023
@martinkilbinger martinkilbinger deleted the n_epoch_test branch September 6, 2023 11:16
martinkilbinger added a commit to martinkilbinger/shapepipe-1 that referenced this pull request Feb 13, 2025
* Added key check and error to multi-epoch mccd interpolation

* .

* More detail in error msg, see PR review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[NEW FEATURE] Key check for multi-epoch input

2 participants