mccd focal-plane plots: fixed coordinate flips for psfex#653
Merged
martinkilbinger merged 1 commit intoCosmoStat:developfrom Sep 8, 2023
Merged
mccd focal-plane plots: fixed coordinate flips for psfex#653martinkilbinger merged 1 commit intoCosmoStat:developfrom
martinkilbinger merged 1 commit intoCosmoStat:developfrom
Conversation
tobias-liaudat
approved these changes
Sep 8, 2023
Member
tobias-liaudat
left a comment
There was a problem hiding this comment.
The changes look good to me, but I have not tested it with data.
The github actions seem to fail in the installation of the pipeline, so it's unrelated to the proposed changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With the
psfexPSF model the CCD MegaCam coordinate flips were not accounted for. This was correct in the oldMeanShapes.py stand-alone script. Now again fixed.
Reviewer Checklist
developbranch