Skip to content

mccd focal-plane plots: fixed coordinate flips for psfex#653

Merged
martinkilbinger merged 1 commit intoCosmoStat:developfrom
martinkilbinger:megacam_flip
Sep 8, 2023
Merged

mccd focal-plane plots: fixed coordinate flips for psfex#653
martinkilbinger merged 1 commit intoCosmoStat:developfrom
martinkilbinger:megacam_flip

Conversation

@martinkilbinger
Copy link
Copy Markdown
Contributor

@martinkilbinger martinkilbinger commented Sep 8, 2023

Summary

With the psfex PSF model the CCD MegaCam coordinate flips were not accounted for. This was correct in the old
MeanShapes.py stand-alone script. Now again fixed.

Reviewer Checklist

Reviewers should tick the following boxes before approving and merging the PR.

  • The PR targets the develop branch
  • The PR is assigned to the developer
  • The PR has appropriate labels
  • The PR is included in appropriate projects and/or milestones
  • The PR includes a clear description of the proposed changes
  • If the PR addresses an open issue the description includes "closes #"
  • The code and documentation style match the current standards
  • Documentation has been added/updated consistently with the code
  • All CI tests are passing
  • API docs have been built and checked at least once (if relevant)
  • All changed files have been checked and comments provided to the developer
  • All of the reviewer's comments have been satisfactorily addressed by the developer

@martinkilbinger martinkilbinger added this to the P3 re-run 2023 milestone Sep 8, 2023
@martinkilbinger martinkilbinger self-assigned this Sep 8, 2023
@martinkilbinger martinkilbinger marked this pull request as ready for review September 8, 2023 12:53
Copy link
Copy Markdown
Member

@tobias-liaudat tobias-liaudat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me, but I have not tested it with data.

The github actions seem to fail in the installation of the pipeline, so it's unrelated to the proposed changes.

@martinkilbinger martinkilbinger merged commit 7509e0d into CosmoStat:develop Sep 8, 2023
@martinkilbinger martinkilbinger deleted the megacam_flip branch September 8, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants