V1.3.6

[martinkilbinger]

Running sp_validation on MCCD v1.3.6 catalogue.

[cailmdaley]

Code review

Found 2 issues:

1. Hardcoded absolute path with username in mask field - The new SP_v1.3.6 config uses /home/guerrini/sp_validation/... which won't work for other users. Other path references in this file use relative paths or the subdir pattern.

sp_validation/notebooks/cosmo_val/cat_config.yaml

Lines 171 to 175 in 35d6fad

	n_psf: 0.752316232272063
	sigma_e: 0.379587601488189
	mask: /home/guerrini/sp_validation/cosmo_inference/data/mask/mask_map_v1.4.6_nside_8192.fits
	psf:
	PSF_flag: FLAG_PSF_HSM

2. Dependencies removed without explanation - Four dependencies were removed (cosmo-numba, cs_util, pymaster, shear_psf_leakage) that are used in multiple files across the codebase. The PR description doesn't mention why these are being removed, which could break existing functionality.

sp_validation/pyproject.toml

Lines 20 to 51 in 35d6fad

	"camb",
	"clmm",
	"colorama",
	"emcee",
	"getdist @ git+https://github.com/benabed/getdist.git@upper_triangle_whisker",
	"h5py",
	"healpy",
	"healsparse",
	"importlib_metadata",
	"joblib>=0.13",
	"jupyter",
	"jupyterlab",
	"jupytext==1.15.1",
	"lenspack",
	"lmfit",
	"numexpr",
	"numpy>=1.14",
	"opencv-python-headless",
	"pyccl",
	"pyarrow",
	"regions",
	"reproject",
	"scipy",
	"seaborn",
	"skyproj",
	"statsmodels",
	"treecorr>=5.0",
	"tqdm",
	"uncertainties"
	]
	# "cosmo-numba @ git+https://github.com/aguinot/cosmo-numba",

---

Generated with Claude Code

_{If this code review was useful, please react with 👍. Otherwise, react with 👎.}

[martinkilbinger]

I agree, the absolute path is not great, but readable for other users (it works for me).
I think I removed the cosmo-numba dependence, because it requires python 3.12. I am about to create a new docker file with 3.12, we can merge this first to get cosmo-numba back.

[cailmdaley]

whoops I was trying out a Claude review command that I didn't know would auto-post the review without allowing me to look at it myself.... sorry. the absolute path is totally fine.

and yes, I see Axel recently updated the minimum Python version for cosmo_numba. you said you've already started a new Dockerfile? i'm also happy take care of this, might be easier for me to do because the sp_validation Docker depends on the ShapePipe docker.

[martinkilbinger]

I added a numpy upgrade to pass some tests.