Conversation
|
This merges the faddat/make-proto-only branch in here, to ensure that it was the needed fix. |
|
@vuong177 @reecepbcups @GNaD13 - guys, getting some pretty serious proto cross-talk here. Also over here: |
|
@reecepbcups fyi I think that the proto changes you made to feeshare resolved the issues here. Update: seems not. Can you take a look at the CI logs? We should run through what could be causing this. idle theory: perhaps the packet forward middleware's protos need to be built with Juno's proto's like mint, meaning that we should likely include it in this repo. |
reecepbcups
left a comment
There was a problem hiding this comment.
Also should add an e2e test for this to ensure it works correctly
|
@reecepbcups I agree about e2e I also think that this is a reasonable place to segue into possibly using IBC test, maybe after we do the UNI deployment. But I still do need to figure out how to use it to simulate the test against the live state. |
|
Push the v13 if we can't figure out where test are, which just leaves oracle left for review |
|
Yeah I think that makes perfect sense |
|
Monday Meeting Pushed to v13 officially |
|
Did a merge here for some testing for: strangelove-ventures/packet-forward-middleware#45 No change to the v13 plan though. |
|
Closing in favor of Andrews more simple PR without go.mod replace (since its merged in now to mainline) |
This PR implements the packet forward middleware.
It's using the branch referenced in this pr:
Since the implementation with ibc v4 is a bit different from v3, reviewers should have a look at:
https://github.com/cosmos/gaia/blob/6880cd7dc22ada30b9dd5737d45f1f90d38a5158/app/keepers/keepers.go#L323
We should also write some e2e tests for this integration, to ensure that it works correctly.