DA-1171 list index names and definitions #63
Conversation
Summary of ChangesHello @AayushTyagi1, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the index management capabilities by introducing a new tool to list and define Couchbase indexes. It provides a structured way to query index metadata, apply filters for specific buckets, scopes, or collections, and automatically generate the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new tool to list indexes from the Couchbase cluster, with options to filter by bucket, scope, and collection. The implementation is well-structured, adding a new utility function to generate CREATE INDEX statements and integrating the new tool into the existing framework.
My review includes a few suggestions to improve robustness and maintainability:
- Adding validation for required data in the index definition generation to prevent potential errors.
- Enhancing error logging to include stack traces for better debugging.
- Correcting a typo in a new utility file's name.
Overall, this is a great addition to the project's capabilities.
src/utils/index_utils.py
Outdated
| url, | ||
| params=params, | ||
| auth=(username, password), | ||
| verify=False, # Disable SSL verification for self-signed certs |
There was a problem hiding this comment.
This is also something we should not do ideally.
We should figure out the right certificate to use from the settings or use the default one for Capella Prod env.
There was a problem hiding this comment.
A good test for this would be the following:
- Test CB Server locally
- Test Capella Dev & Prod environment
- Test CB Server locally with user definted certs
There was a problem hiding this comment.
Tested locally
Capella Dev
Capella Prod
Third case not done but tested non prod with user defined cert and it worked
| The host extracted from the connection string | ||
| """ | ||
| # Parse the connection string | ||
| parsed = urlparse(connection_string) |
There was a problem hiding this comment.
Connection strings with multiple hosts will currently fail
connection_string = "couchbases://192.168.106.130,192.168.106.129,192.168.106.128" will call all 3 nodes when it should only call one of the nodes (ideally the one with index service running but for simplicity we can ignore it for now & handle it later if required)
Fetching indexes from REST API: https://192.168.106.130,192.168.106.129,192.168.106.128:19102/getIndexStatus
Uh oh!
There was an error while loading. Please reload this page.