Processes batching and event threshold #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtursKadikis
requested changes
Apr 21, 2023
Member
ArtursKadikis
left a comment
ArtursKadikis
left a comment
There was a problem hiding this comment.
"stopping the process" none of this
potentially:
process -> processing
tests need to be updated for setting the value after init. That should work
examples/example_integration.cpp
Outdated
| ct.start("YOUR_APP_KEY", "https://try.count.ly", 443, true); | ||
| ct.SetMaxEventsPerMessage(10); | ||
| ct.setAutomaticSessionUpdateInterval(5); | ||
| ct.setMaxRequestQueueProcessingSize(2); |
Member
There was a problem hiding this comment.
we need a comment here and a not that this isn't needed for production
src/countly.cpp
Outdated
| * @param requestQueueProcessingSize: max size of requests to process at a time | ||
| */ | ||
| void Countly::setMaxRequestQueueProcessingSize(unsigned int requestQueueProcessingSize) { | ||
| if (is_sdk_initialized) { |
Member
There was a problem hiding this comment.
should be usable before or after init
src/request_module.cpp
Outdated
| processedRequestsCounter++; | ||
|
|
||
| if (processedRequestsCounter > impl->_configuration->requestQueueProcessingThreshold) { | ||
| impl->_logger->log(LogLevel::DEBUG, cly::utils::format_string("[RequestModule] processQueue: Processing limit has been reached, stopping the process.")); |
Member
There was a problem hiding this comment.
Processing limit -> Processing max batch size
tests/config.cpp
Outdated
| ct.setAutomaticSessionUpdateInterval(5); | ||
| ct.setSalt("salt"); | ||
| ct.setMaxRequestQueueSize(10); | ||
| ct.setMaxRequestQueueProcessingSize(10); |
Member
There was a problem hiding this comment.
doesn't belong here. is false
ArtursKadikis
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.