[Sdk 927] Request Module added #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
request module
one deadlock remains
mutext shared ptr added
Unit tests fixed
ArtursKadikis
requested changes
Sep 19, 2022
Member
ArtursKadikis
left a comment
ArtursKadikis
left a comment
There was a problem hiding this comment.
Mutex changes should be in a separate PR.
"request builder" functionality should be integrated into "request module"
ArtursKadikis
requested changes
Sep 20, 2022
Member
ArtursKadikis
left a comment
ArtursKadikis
left a comment
There was a problem hiding this comment.
Fix "debugReturnStateOfRQ".
src/request_module.cpp
Outdated
| RequestModule::~RequestModule() { impl.reset(); } | ||
|
|
||
| void RequestModule::addRequestToQueue(const std::map<std::string, std::string> &data) { | ||
| if (impl->_configuration->requestQueueThreshold == impl->request_queue.size()) { |
include/countly.hpp
Outdated
| * It is currently added as a temporary workaround. | ||
| */ | ||
| inline void processRQDebug() { processRequestQueue(); } | ||
| inline void processRQDebug() { requestModule->processQueue(mutex); } |
include/countly.hpp
Outdated
| inline void processRQDebug() { requestModule->processQueue(mutex); } | ||
|
|
||
| inline void clearRequestQueue() { request_queue.clear(); } | ||
| inline void clearRequestQueue() { requestModule->clearRequestQueue(); } |
include/countly/request_module.hpp
Outdated
| #include "countly/logger_module.hpp" | ||
| #include "countly/request_builder.hpp" | ||
|
|
||
| #ifdef _WIN32 |
Member
There was a problem hiding this comment.
move this to the same place as other defs
…into sdk-927 # Conflicts: # include/countly.hpp # src/countly.cpp
ArtursKadikis
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.