[Sdk 911] Crash module added #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
request module
one deadlock remains
mutext shared ptr added
Unit tests fixed
…into sdk-927 # Conflicts: # include/countly.hpp # src/countly.cpp
…into sdk-911 # Conflicts: # CMakeLists.txt
unit tests added
ArtursKadikis
requested changes
Sep 21, 2022
Member
ArtursKadikis
left a comment
ArtursKadikis
left a comment
There was a problem hiding this comment.
Currently we have:
- BC, crash
Add a few more tests:
- no BC, only crash
- crash with empty strings and no metrics, no BC
- add BC, crash, add BC, crash (should have all BC)
create a generic validator for crash requests
ArtursKadikis
requested changes
Sep 21, 2022
ArtursKadikis
requested changes
Sep 22, 2022
Member
ArtursKadikis
left a comment
ArtursKadikis
left a comment
There was a problem hiding this comment.
Tests should be commented way more.
sample app updated
ArtursKadikis
approved these changes
Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.