Skip to content

hsts hide for later merge #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kanwarujjaval merged 1 commit into from
May 9, 2026
+13 −4
Merged

hsts hide for later merge #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions charts/countly-web-ui-canary/templates/ingress-master.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,13 @@ metadata:
# ssl-redirect default flips to true when a tls: block is set; keep
# plain HTTP open for the ACME challenge on issuance and renewal.
nginx.org/ssl-redirect: "false"
{{- if .Values.ingress.tls.proxyHideHSTS }}
# F5 NIC ignores `nginx.org/proxy-hide-headers` on minions in mergeable
# mode — it only honors it at master. Strip HSTS leaking from the
# stable backend so a misconfigured canary can't pin a browser to
# expecting valid TLS for <slug>.v2.count.ly after the canary is gone.
nginx.org/proxy-hide-headers: "Strict-Transport-Security"
{{- end }}
{{- include "canary.ingressAnnotations" . | nindent 4 }}
spec:
ingressClassName: {{ .Values.ingress.className }}
Expand Down
10 changes: 6 additions & 4 deletions charts/countly-web-ui-canary/templates/ingress-minion.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,12 @@ metadata:
annotations:
nginx.org/mergeable-ingress-type: minion
{{- if .Values.ingress.tls.proxyHideHSTS }}
# Strip HSTS leaking from the stable backend so a misconfigured canary
# can't pin a browser to expecting valid TLS for <slug>.v2.count.ly
# after the canary is torn down.
nginx.org/proxy-hide-headers: "Strict-Transport-Security"
# Snippet fallback: F5 NIC's `nginx.org/proxy-hide-headers` annotation
# is master-level, but proxy_hide_header is a per-location directive,
# so we also drop it directly into each minion path's location block.
# Belt-and-suspenders against HSTS leaking from the stable backend.
nginx.org/location-snippets: |
proxy_hide_header Strict-Transport-Security;
{{- end }}
{{- include "canary.ingressAnnotations" . | nindent 4 }}
spec:
Expand Down
Loading