Refactor Building and Time functions into Models#1718
Draft
AngelsandDevsLOL wants to merge 7 commits into
Draft
Conversation
7757b19 to
9a83761
Compare
Coverage Report for CI Build 8539Coverage increased (+0.4%) to 58.634%Details
Uncovered Changes
Coverage Regressions28 previously-covered lines in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Moves Building-related functions out of
Database/Tables.hsandWebParsing/ArtSciParser.hsinto a newModels/Building.hs, following a similar pattern asModels/Course.hsandModels/Meeting.hs. This PR also moves the Time-related functions out ofDatabase/Tables.hsintoModels/Time.hs.buildingsCSV,parseBuildings,getBuildingsFromCSV,getBuilding, are moved toModels/Building.hs.buildTimeandbuildTimesare moved toModels/Time.hs.All imports using the functions were updated to find the corresponding functions in
Models/Building.hsandModels/Time.hs....
Screenshots of your changes (if applicable)
Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments