Skip to content

Conversation

@benrowe
Copy link
Contributor

@benrowe benrowe commented May 15, 2025

Updated composer to support laravel 11/12

  • Additionally I removed the composer.lock (shouldn't be commited for packages).
  • Added a github action to run the tests.
  • Minor updates to the composer file.

@benrowe benrowe marked this pull request as ready for review May 15, 2025 21:45
@benrowe benrowe force-pushed the feature/laravel-11-support branch from 60c83af to 98281e0 Compare May 15, 2025 22:11
"name": "covergenius/json-diff",
"description": "JSON Diff",
"type": "library",
"license": "GNUv3",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

composer validate does not recognise this license key.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! ❤️

@benrowe benrowe changed the title Add laravel 11 support Add laravel 11/12 support May 15, 2025
@JetTheCat JetTheCat merged commit 1834785 into CoverGenius:main May 16, 2025
Copy link
Contributor

@arg2009 arg2009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful PR 😍

So clean and neat!

Comment on lines +18 to +19
# OS
.DS_Store
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget Windows! 🥳

Suggested change
# OS
.DS_Store
# OS
.DS_Store
Thumbs.db

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thing of beauty 😍

"name": "covergenius/json-diff",
"description": "JSON Diff",
"type": "library",
"license": "GNUv3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants