Fix Ord codegen to use other < self in reverse branch

[Copilot]

The generated Ord::cmp for method-based operator< used other.<op>(other) in its second branch, which can never evaluate true and therefore suppresses Ordering::Greater. This change aligns that branch with the intended reverse comparison (other.<op>(self)), matching existing model-specific behavior.

• Codegen fix (converter.cpp)

  • In Converter::ConvertOrdAndPartialOrdTraits (OO_Less + method operator path), changed:
    • second_branch = other.<op>(other) → second_branch = other.<op>(self)

• Golden output update (unsafe unit fixture)

  • Updated tests/unit/out/unsafe/operator_less_than.rs to reflect corrected generation in both:
    • Ord::cmp reverse branch
    • PartialEq::eq reverse comparison branch

// before
second_branch = std::format("other.{}(other)", GetOverloadedOperator(op));

// after
second_branch = std::format("other.{}(self)", GetOverloadedOperator(op));

Original prompt

Please apply the following diffs and create a pull request.
Once the PR is ready, give it a title based on the messages of the fixes being applied.

[{"message":"The second branch of the `Ord` comparison incorrectly compares `other` against itself (`other.lt(other)`) instead of comparing `other` against `self` (`other.lt(self)`). This means the generated `cmp` method will never produce `std::cmp::Ordering::Greater`, since `other < other` is always false. The `ConverterRefCount` override at line 418 correctly uses `self` in the equivalent position. This argument should be `self`, not `other`.","fixFiles":[{"filePath":"cpp2rust/converter/converter.cpp","diff":"diff --git a/cpp2rust/converter/converter.cpp b/cpp2rust/converter/converter.cpp\n--- a/cpp2rust/converter/converter.cpp\n+++ b/cpp2rust/converter/converter.cpp\n@@ -3678,7 +3678,7 @@\n   case clang::OO_Less:\n     if (clang::isa<clang::CXXMethodDecl>(op)) {\n       first_branch = std::format(\"self.{}(other)\", GetOverloadedOperator(op));\n-      second_branch = std::format(\"other.{}(other)\", GetOverloadedOperator(op));\n+      second_branch = std::format(\"other.{}(self)\", GetOverloadedOperator(op));\n     } else {\n       first_branch = std::format(\"{}(self, other)\", GetOverloadedOperator(op));\n       second_branch = std::format(\"{}(other, self)\", GetOverloadedOperator(op));\n"}]}]