Disable verbose logging by default#50
Merged
nunoplopes merged 5 commits intoCpp2Rust:masterfrom May 3, 2026
Merged
Conversation
nunoplopes
reviewed
May 3, 2026
| } | ||
| } | ||
| llvm::errs() << "Unknown printf format: " << format << "\n"; | ||
| verrs() << "Unknown printf format: " << format << "\n"; |
Contributor
There was a problem hiding this comment.
These kinds of things must be printed always. This is not about being verbose or not
nunoplopes
reviewed
May 3, 2026
| StrCat(ends_newline ? "eprintln!(" : "eprint!("); | ||
| } else { | ||
| llvm::errs() << "Uknown fprintf fd: " << fd << "\n"; | ||
| verrs() << "Uknown fprintf fd: " << fd << "\n"; |
nunoplopes
reviewed
May 3, 2026
| void SetVerbose(bool verbose); | ||
|
|
||
| llvm::raw_ostream &verrs(); | ||
| llvm::raw_ostream &vouts(); |
Contributor
There was a problem hiding this comment.
we probably only need one stream for verbose
Contributor
Author
There was a problem hiding this comment.
I removed vouts and renamed verrs to log
lucic71
added a commit
to lucic71/cpp2rust
that referenced
this pull request
May 3, 2026
Logging can be re-enabled using the `--verbose` option
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Logging can be re-enabled using the
--verboseoption