Merged
Conversation
added 5 commits
May 28, 2025 09:29
With apple's latest clang implementation, this warning fired as an error when including boost::nowide. Turn the warning off.
when adding resource files.
Contributor
|
No warnings, LGTM! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #1097 +/- ##
===============================================
- Coverage 88.48% 88.46% -0.02%
===============================================
Files 253 253
Lines 12240 12240
===============================================
- Hits 10830 10828 -2
- Misses 1410 1412 +2 🚀 New features to boost your workflow:
|
Contributor
|
No warnings, LGTM! |
jeffdiclemente
approved these changes
May 28, 2025
RobertLauferElektrobit
pushed a commit
to insi-eb/CppMicroServices-cpp14
that referenced
this pull request
Jul 25, 2025
Fixes CppMicroServices#161 * found spots to modify. * issue 161.2 coded. * fixed a logic error in issue 161.2 * Added a "-Wno-missing-template-arg-list-after-template-kw" With apple's latest clang implementation, this warning fired as an error when including boost::nowide. Turn the warning off. * Issue 161.3: Early check for absolute path when adding resource files. * i161.3: Alternate code for mingw. std::filesystem not compatible. --------- Co-authored-by: Michael Carney <carney@macmini.mynetworksettings.com>
Merged
jeffdiclemente
pushed a commit
that referenced
this pull request
Jul 25, 2025
* I161 (#1097) Fixes #161 * found spots to modify. * issue 161.2 coded. * fixed a logic error in issue 161.2 * Added a "-Wno-missing-template-arg-list-after-template-kw" With apple's latest clang implementation, this warning fired as an error when including boost::nowide. Turn the warning off. * Issue 161.3: Early check for absolute path when adding resource files. * i161.3: Alternate code for mingw. std::filesystem not compatible. --------- Co-authored-by: Michael Carney <carney@macmini.mynetworksettings.com> * adapt for C++14 --------- Co-authored-by: carneyweb <mike@carneyweb.com> Co-authored-by: Michael Carney <carney@macmini.mynetworksettings.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial pull request for issue 161. I've dealt with parts 2 & 3, and I think that part 1 is moot.