Cleanup and update to PHP5 class conventions #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__cosntruct()execution.Also minimized operation overhead by moving initial node list loading to end of successful login, instead of on every action possible post-login. (There were checks to determine if upstream requests were required to fulfill this need, but that check itself presents an amount of overhead which can be undesirable in a high performance, high request load situation.)
Additionally, removed superfluous
pve_from property and method names. The fact that they are part of thePVE2_APIclass tells us that much of their nature. The fact that all were in protected/private scope makes the extra characters even more unnecessary.NOTE:
diffisn't very smart about detecting when newlines are added to existing text, so the first several changes (until about line 83 in the old/53 in the new) are less drastic than they appear. (gitusesdiffrather than replicate its functionality because Linus believes in not reinventing wheels he doesn't have to; git is obviously a wheel he had to 😁 )