Skip to content

API allows user to sign up for an account and request a community #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kaylawoodbury merged 8 commits into from
Apr 15, 2020
Merged

API allows user to sign up for an account and request a community #10

kaylawoodbury merged 8 commits into from
Apr 15, 2020

Conversation

@pgaunitz
Copy link
Contributor

@pgaunitz pgaunitz commented Apr 15, 2020

PT board URL

User Story

As a user
In order to be part of a community
I would like to be able to create an account with a community request

Changes proposed in this pull request:

  • Adds community model
  • Adds community controller
  • Adds community status to user, pending, accepted, rejected
  • Adds association between community and user

What I have learned working on this feature:

  • How generate random alphanumeric code using SecureRandom
  • Learned to visualize data flow in the app

kfrostare
kfrostare reviewed Apr 15, 2020
View reviewed changes
kfrostare
kfrostare reviewed Apr 15, 2020
View reviewed changes
kfrostare
kfrostare reviewed Apr 15, 2020
View reviewed changes
kaylawoodbury
kaylawoodbury approved these changes Apr 15, 2020
View reviewed changes
Copy link
Contributor

@kaylawoodbury kaylawoodbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think there is one comment that can be removed, otherwise I think this looks good!

@kaylawoodbury kaylawoodbury merged commit 5c77096 into CraftAcademy:development Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kfrostare kfrostare kfrostare left review comments

@kaylawoodbury kaylawoodbury kaylawoodbury approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pgaunitz @kaylawoodbury @kfrostare @emtalen