Skip to content

Bug Hunt - Accepting Requests and Showing Pongs #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pgaunitz merged 4 commits into from
Apr 18, 2020
Merged

Bug Hunt - Accepting Requests and Showing Pongs #17

pgaunitz merged 4 commits into from
Apr 18, 2020

Conversation

@emtalen
Copy link
Contributor

@emtalen emtalen commented Apr 18, 2020

PT board URL

User Story

As a development team
In order to have a working app
We would like to fix any bugs we run into

Changes proposed in this pull request:

  • Removes the status of pongs from the ping serializer
  • Changes so ping show request sends in user id as param

What I have learned working on this feature:

  • Do dry runs, a lot.

kaylawoodbury
kaylawoodbury approved these changes Apr 18, 2020
View reviewed changes
Copy link
Contributor

@kaylawoodbury kaylawoodbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and great work finding and resolving these!

@pgaunitz pgaunitz merged commit 3d853ca into CraftAcademy:development Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaylawoodbury kaylawoodbury kaylawoodbury approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@emtalen @kaylawoodbury @pgaunitz @johanbounce