Api provides authentication for Admin #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I have no notes, looks good to me /Kf |
johanbounce
approved these changes
Apr 12, 2020
Contributor
johanbounce
left a comment
johanbounce
left a comment
There was a problem hiding this comment.
very handsome pull request
kaylawoodbury
approved these changes
Apr 12, 2020
Contributor
kaylawoodbury
left a comment
kaylawoodbury
left a comment
There was a problem hiding this comment.
Looks good and thorough, thanks for setting up the role for admin with the initial set up. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PT board URL
User Story
Changes proposed in this pull request:
What I have learned working on this feature:
Packages/Gems added