Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Demonstration of a bug in deepStrictEqual tracked by nodejs#62422, where two structurally equal arrays can throw the following error in specific cases:
It is my understanding tht it is not intended behavior for deepStrictEqual to ever throw when objects have the same structure but are not reference-equal.
It is also my understanding that the behavior of deepStrictEqual should not be impacted by previous calls to deepStrictEqual.
As both of these assumptions seem to be violated, this appears to be a bug which regressed sometime after v22.22.1 (which did not have this behavior).