Skip to content

Make cratis update installation-aware with Homebrew update+upgrade and unified post-command update hints#22

Merged
einari merged 3 commits into
mainfrom
copilot/update-smart-command-logic
May 16, 2026
Merged

Make cratis update installation-aware with Homebrew update+upgrade and unified post-command update hints#22
einari merged 3 commits into
mainfrom
copilot/update-smart-command-logic

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 16, 2026

  • Inspect current branch state and verify whether brew update is present in code
  • If missing, add/restore brew update before Homebrew upgrade in self-update flow
  • Run focused tests for update behavior
  • Run security scan and finalize
  • Commit/push and reply to PR comment with commit hash

Copilot AI linked an issue May 16, 2026 that may be closed by this pull request
Copilot AI changed the title [WIP] Update command to handle dotnet and brew updates more intelligently Make cratis update installation-aware and unify post-command update hints May 16, 2026
Copilot finished work on behalf of einari May 16, 2026 07:20
Copilot AI requested a review from einari May 16, 2026 07:20
@einari
Copy link
Copy Markdown
Contributor

einari commented May 16, 2026

@copilot Great. Since cratis is not part of the default Homebrew tap, we need to run brew update and then the upgrade.

Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 16, 2026

@copilot Great. Since cratis is not part of the default Homebrew tap, we need to run brew update and then the upgrade.

Implemented in db70895. Homebrew updates now run brew update first and then brew upgrade cratis in the self-update flow, with focused specs added for the pre-update Homebrew command behavior.

Copilot AI changed the title Make cratis update installation-aware and unify post-command update hints Make cratis update installation-aware with Homebrew update+upgrade and unified post-command update hints May 16, 2026
Copilot finished work on behalf of einari May 16, 2026 07:29
@einari
Copy link
Copy Markdown
Contributor

einari commented May 16, 2026

@copilot Weird, you said brew update as added - but its not in the code

Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 16, 2026

@copilot Weird, you said brew update as added - but its not in the code

It is in the branch at db70895: Source/Cli/CliUpdate.cs adds CreatePreUpdateProcessStartInfo() with brew + update, and Source/Cli/Commands/Version/SelfUpdateCommand.cs calls it before CreateUpdateProcessStartInfo() (brew upgrade cratis). If you want, I can also fold it into a single Homebrew command path to make it more obvious in one place.

Copilot finished work on behalf of einari May 16, 2026 07:35
@einari einari marked this pull request as ready for review May 16, 2026 07:38
@einari einari merged commit 8547a3c into main May 16, 2026
2 checks passed
@einari einari deleted the copilot/update-smart-command-logic branch May 16, 2026 07:38
@einari einari added the patch label May 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update command should be a bit smarter

2 participants