test(core): improve extractLinks error handling coverage#36
test(core): improve extractLinks error handling coverage#36saurabhsharma2u merged 1 commit intomainfrom
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Restore try/catch block around cheerio.load in extractLinks - Add new test case for non-Error exceptions in extract.test.ts - Add comments explaining mocking strategy
b73806f to
db37499
Compare
Improved error handling coverage for
extractLinksin@crawlith/core.Changes:
try/catchblock aroundcheerio.loadinplugins/core/src/crawler/extract.tsto prevent the crawler from crashing on malformed HTML inputs that might causecheerioto throw.plugins/core/tests/extract.test.tsby:should handle non-Error exceptions gracefullyto ensure the catch block handles thrown strings/objects correctly.cheeriomocking strategy usingvi.mockandimportOriginal.Verified that all tests in
extract.test.tspass and coverage is maintained.PR created automatically by Jules for task 2828922681014962528 started by @saurabhsharma2u