Refactor Graph edge key storage to use JSON serialization#7
Conversation
- Introduced `Graph.getEdgeKey` and `Graph.parseEdgeKey` to encapsulate edge key generation logic. - Replaced `|` delimiter with `JSON.stringify` to ensure robustness against delimiter collisions in URLs. - Updated `Graph` methods `addEdge`, `getEdges`, and `fromJSON` to use the new key management methods. - Refactored `plugins/core/src/graph/duplicate.ts` to use the new `Graph` static methods for edge processing. - Updated `plugins/core/tests/duplicate.test.ts` to use `graph.addEdge` and `Graph.getEdgeKey`, removing fragile manual string concatenation.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
saurabhsharma2u
deleted the
fix-fragile-edge-keys-16326270772881790958
branch
1 participant
This PR addresses a code health issue in
plugins/core/src/graph/graph.tswhere edge keys were constructed using a simple pipe|delimiter. This was fragile because URLs containing|would break the key parsing logic.The fix involves:
Graph.getEdgeKeyandGraph.parseEdgeKey.JSON.stringify([source, target])as the key format, which safely handles any character in URLs.Graphclass andduplicate.tsto use these new methods.duplicate.test.tsto avoid manual key construction, improving test robustness.Verification:
vitestforplugins/coreincludingduplicate.test.ts,metrics.test.ts, andcrawler.test.ts.vitestforplugins/clito ensure no regressions in downstream usage.PR created automatically by Jules for task 16326270772881790958 started by @saurabhsharma2u