π§ͺ Add test for DomainFilter invalid hostname fallback#8
Conversation
Added a test case to `plugins/core/tests/scope.test.ts` to verify that `DomainFilter` correctly handles invalid hostnames (like `[`) that cause the `URL` constructor to throw. This ensures the fallback to the raw string works as expected.
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
plugins/core/tests/scope.test.tsto verify the fallback mechanism inDomainFilter.normalizewhennew URL()throws an error.[) is passed toDomainFilter, ensuring it is normalized to the raw string instead of crashing.DomainFilter.PR created automatically by Jules for task 15784481694884848104 started by @saurabhsharma2u