Skip to content

πŸ§ͺ Add test for DomainFilter invalid hostname fallback#8

Merged
saurabhsharma2u merged 1 commit intomainfrom
test/domain-filter-fallback-15784481694884848104
Feb 25, 2026
Merged

πŸ§ͺ Add test for DomainFilter invalid hostname fallback#8
saurabhsharma2u merged 1 commit intomainfrom
test/domain-filter-fallback-15784481694884848104

Conversation

@saurabhsharma2u
Copy link
Copy Markdown
Contributor

  • 🎯 What: Added a unit test to plugins/core/tests/scope.test.ts to verify the fallback mechanism in DomainFilter.normalize when new URL() throws an error.
  • πŸ“Š Coverage: Covered the case where an invalid hostname (e.g., [) is passed to DomainFilter, ensuring it is normalized to the raw string instead of crashing.
  • ✨ Result: Increased test coverage for error handling in DomainFilter.

PR created automatically by Jules for task 15784481694884848104 started by @saurabhsharma2u

Added a test case to `plugins/core/tests/scope.test.ts` to verify that `DomainFilter` correctly handles invalid hostnames (like `[`) that cause the `URL` constructor to throw. This ensures the fallback to the raw string works as expected.
@google-labs-jules
Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@saurabhsharma2u saurabhsharma2u marked this pull request as ready for review February 25, 2026 14:35
@saurabhsharma2u saurabhsharma2u merged commit 0aca6bf into main Feb 25, 2026
6 checks passed
@saurabhsharma2u saurabhsharma2u deleted the test/domain-filter-fallback-15784481694884848104 branch February 25, 2026 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant