CASMPET-6924: ncnHealthChecks.sh: etcd_cluster_balance: Fix syntax error; remove superfluous Kubernetes calls #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mharding-hpe
requested review from
bo-quan,
kimjensen-hpe,
leliasen-hpe,
ndavidson-hpe and
spillerc-hpe
…ror; remove superfluous Kubernetes calls
mharding-hpe
force-pushed
the
CASMPET-6924
branch
from
b25b217 to
dd6c6c2
Compare
mtupitsyn
approved these changes
Mar 15, 2024
bo-quan
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary and Scope
While testing my changes for a different PR, I stumbled across a few Bash syntax errors in the
etcd_cluster_balancefunction inncnHealthChecks.sh. And while fixing those, I noticed that the function was making the same Kubernetes calls twice in a row -- once to show the user, and the second time to pipe throughwcto count the lines. I modified that so that it could accomplish both things with only one call to Kubernetes -- which speeds it up appreciably.Issues and Related PRs
The syntax errors were injected by this PR for CASMPET-6827.
Testing
I tested the updated code on mug.
Risks and Mitigations
Low risk. Right now the syntax error prevents the function from working.
Pull Request Checklist