Skip to content

Conversation

@ashao
Copy link
Member

@ashao ashao commented Mar 4, 2025

Fixes a bug in the Fortran client where (on compilers that support automatic destruction) the program would segfault if the user had manually destroyed the dataset. This behaviour was tracked down to an error in the C-client where only the one-level de-referenced pointer was being set to NULL but not the actual double-pointer.

@ashao ashao force-pushed the ftn_destructor_bug branch from 4f5471e to f7c9cd5 Compare June 17, 2025 09:26
@codecov
Copy link

codecov bot commented Jun 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.63%. Comparing base (4937fbd) to head (0a12086).
⚠️ Report is 20 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop     #525       +/-   ##
============================================
- Coverage    95.92%   57.63%   -38.30%     
============================================
  Files           10      147      +137     
  Lines          884    11908    +11024     
  Branches         0     1131     +1131     
============================================
+ Hits           848     6863     +6015     
- Misses          36     4894     +4858     
- Partials         0      151      +151     
Files with missing lines Coverage Δ
src/c/c_dataset.cpp 62.71% <ø> (ø)
src/fortran/dataset.F90 92.30% <100.00%> (ø)
tests/fortran/client_test_dataset.F90 100.00% <100.00%> (ø)

... and 134 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ashao ashao force-pushed the ftn_destructor_bug branch from f7c9cd5 to 19ec3ea Compare June 17, 2025 09:40
Copy link
Collaborator

@al-rigazzi al-rigazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor typo in the changelog, but approving as it looks good otherwise. Thanks for fixing this user issue!

@ashao ashao merged commit 9655f0c into CrayLabs:develop Sep 10, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants