Skip to content

Conversation

@jfocco
Copy link
Collaborator

@jfocco jfocco commented Jun 1, 2020

Changed node version from 8 to 10 for the Cloud Functions.

@jfocco jfocco added good first issue Good for newcomers dependencies Pull requests that update a dependency file labels Jun 1, 2020
@jfocco jfocco requested review from MateoKruk and tpiaggio June 1, 2020 15:17
@MateoKruk
Copy link
Contributor

I think that your branch is not up to date with master.

Copy link
Contributor

@MateoKruk MateoKruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@tpiaggio tpiaggio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MateoKruk MateoKruk merged commit 4be0d6d into master Jun 2, 2020
@MateoKruk MateoKruk deleted the feature/upgrade-functions-node-version branch June 2, 2020 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file good first issue Good for newcomers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants