Skip to content

Solved profile editing issue#40

Merged
TOPOFGR merged 1 commit intomasterfrom
hotfix/modify-user
Jun 2, 2020
Merged

Solved profile editing issue#40
TOPOFGR merged 1 commit intomasterfrom
hotfix/modify-user

Conversation

@TOPOFGR
Copy link
Copy Markdown
Contributor

@TOPOFGR TOPOFGR commented Jun 1, 2020

Details:
Solved issue for users editing their own profile.

Issue:
Users could not edit their profile due to logoUrl being brought from the users state from the Redux store.

Fix:
Condition to take the logoUrl from the auth state when the user is editing it´s own profile.

@TOPOFGR TOPOFGR requested review from MateoKruk and tpiaggio June 1, 2020 17:42
@TOPOFGR TOPOFGR self-assigned this Jun 1, 2020
Copy link
Copy Markdown
Member

@tpiaggio tpiaggio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@MateoKruk MateoKruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one 👍

@tpiaggio tpiaggio force-pushed the hotfix/modify-user branch from e62a5b2 to 1be17c2 Compare June 2, 2020 19:45
@tpiaggio tpiaggio force-pushed the hotfix/modify-user branch from 1be17c2 to 3d34264 Compare June 2, 2020 19:49
@TOPOFGR TOPOFGR merged commit c31c09f into master Jun 2, 2020
@TOPOFGR TOPOFGR deleted the hotfix/modify-user branch June 2, 2020 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants