Skip to content

Invert sign for gird power balance #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
darthsharp merged 1 commit into from
Apr 20, 2026
+5 −5
Merged

Invert sign for gird power balance #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions source/CreativeCoders.SmartMeter.DataProcessing/SmlValueProcessor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,14 +84,14 @@ private void PushNewCurrentValue(SmartMeterValue value)
case SmartMeterValueType.CurrentPurchasingPower:
_valueSubject.OnNext(new SmartMeterValue(SmartMeterValueType.GridPowerBalance)
{
Value = value.Value * -1,
Value = value.Value,
WriteAsJson = false
});
break;
case SmartMeterValueType.CurrentSellingPower:
_valueSubject.OnNext(new SmartMeterValue(SmartMeterValueType.GridPowerBalance)
{
Value = value.Value,
Value = value.Value * -1,
WriteAsJson = false
});
break;
Expand Down
6 changes: 3 additions & 3 deletions tests/CreativeCoders.SmartMeter.DataProcessing.Tests/SmlValueProcessorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public void Subscribe_WithTwoPurchasedEnergyValues_ShouldReturnTotalAndCurrentAn
{
// Arrange
var expectedBalanceValue = (smlValueValue2 - smlValueValue1) * 60;
if (smlValueType == SmlValueType.PurchasedEnergy)
if (smlValueType == SmlValueType.SoldEnergy)
{
expectedBalanceValue *= -1;
}
Expand Down Expand Up @@ -185,7 +185,7 @@ public void Subscribe_WithUnchangedValueAfterTwentyOneSeconds_EmitsZeroCurrentPo
}

[Fact]
public void Subscribe_WithPurchasedEnergyGap_EmitsNegativeGridPowerBalance()
public void Subscribe_WithPurchasedEnergyGap_EmitsPositiveGridPowerBalance()
{
// Arrange
var results = new List<SmartMeterValue>();
Expand All @@ -201,7 +201,7 @@ public void Subscribe_WithPurchasedEnergyGap_EmitsNegativeGridPowerBalance()

// Assert
var balance = results.Single(x => x.Type == SmartMeterValueType.GridPowerBalance);
balance.Value.Should().BeLessThan(0m);
balance.Value.Should().BeGreaterThan(0m);
balance.WriteAsJson.Should().BeFalse();
}

Expand Down